-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport #1465: @site and @navroot endpoints #1702
Conversation
@erral thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
See: plone/volto#5185 |
eh... how are we testing the 7.x.x branch in python 2.7? It is not available on github actions... @plone/restapi-team |
@erral There is still a Jenkins job which tests on Python 2.7 |
@erral I remember that you can use an old ubuntu image on GHA that still ships with Python 2.7. Not sure if that still is the case though. It gets harder and harder to support Python 2.7 these days :( |
where all robot tests fail 😒 |
@erral There are some syntax errors in Python 2 |
@erral I think it would be fine to disable the new endpoints entirely for Plone 4.3 (i.e. with conditional zcml, plus skipping the tests on 4.3) |
@davisagli the whole point of this PR was to bring I will try to fix the issues. |
@erral Oops, right, I forgot. Carry on, then. |
@jenkins-plone-org please run jobs |
Green! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erral Thanks!
I have released this in |
Backport of #1465 to 7.x.x to have it for plone/volto#5185